[ 
https://issues.apache.org/jira/browse/QPID-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864135#comment-15864135
 ] 

Rob Godfrey commented on QPID-7670:
-----------------------------------

{quote}
The changes look good, however, I'm concerned about possibility of multiple 
ticks invocations for the same ticker.
{quote}

So the scheduled tick job always calls tick with the current time and always 
within a synchronized block around the connection wrapper.  The tickers 
themselves should take responsibility for deciding if they need to take any 
action or not.  I think the issue you highlight here (particularly for AMQP 
1.0) is that the async close for sessions is not correctly implemented (since 
it allows the same session to send multiple ends).  This is a different bug 
(that I don't think is limited to WebSockets / ticker timeouts) and should be 
raised separately (and maybe scheduled into a 6.1.2 as it is a bug that should 
be fixed.

> [Java Broker] WebSocket transport does not respect AMQP idle timeout
> --------------------------------------------------------------------
>
>                 Key: QPID-7670
>                 URL: https://issues.apache.org/jira/browse/QPID-7670
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: qpid-java-6.0.6, qpid-java-6.1.1
>            Reporter: Rob Godfrey
>            Assignee: Rob Godfrey
>             Fix For: qpid-java-7.0, qpid-java-6.1.2
>
>
> The websocket transport does not currently respect the requested AMQP idle 
> timeout settings.  Moreover it does enforce an arbitrary Jetty setting for 
> read timeout, which it does not inform the client about



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to