Github user gemmellr commented on the issue:
https://github.com/apache/qpid-proton-j/pull/4
I've had a look and have some comments:
- The changes should inclulde some tests for the new feature.
- The setter javadoc should make clear that this overrides any other
configuration that might have otherwise been uesd to create a context, and the
getter only returns anything set with the setter.
- The changes introduce various lines with whitespace errors (lines with
only spaces, mixtures of tabs and space indents). Please ensure you use spaces
only, and empty lines are in fact empty.
- The change in IoHandler to force EXTERNAL is unrelated and not required
here, please remove it.
Some pointers for any updates and future PRs (info which I'll add to the
website/repo's at some point soon, so folks can see it in advance, or we can
reference it later):
- If you raise the PR with the JIRA key in the title (e.g. see #3), a bot
will raise a note against the JIRA for open/close and also relay future
comments to the JIRA.
- Similarly if you could include the key in the commit log message, that
way a bot records it on the JIRA upon eventual commit.
- In general PRs should be a single commit rebased to sit at the HEAD of
the current master, without any merge commits. Multiple commits can be useful
if its a many-layered change and the steps help evaluate it however.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
