[
https://issues.apache.org/jira/browse/PROTON-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890552#comment-15890552
]
ASF GitHub Bot commented on PROTON-1410:
----------------------------------------
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton-j/pull/6
Both qpid-jms and artemis are holding this type of TLS somewhere else.
I am creating my own version of an object that is only holding the byte[]
of the message, and I only need it to decode and re-encode headers and
application properties.
-
https://github.com/apache/qpid-jms/blob/master/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpCodec.java#L61-L76
-
https://github.com/apache/activemq-artemis/blob/master/artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/message/JMSMappingOutboundTransformer.java#L109-L124
My final proposal would be to have it singleton, but meanwhile I still need
that functionality.. I think it would be better to be reusing the same TLS
that's already used inside ProtonJMS instead of duplicating the variable.
I am expanding the usage to a new AMQPMessage on my branch, and it's using
a delegate approach where I will try to not load the Message, and only parse
the header and eventually applicationProperties:
> Move MessageImpl::TLS to an utility class
> -----------------------------------------
>
> Key: PROTON-1410
> URL: https://issues.apache.org/jira/browse/PROTON-1410
> Project: Qpid Proton
> Issue Type: Improvement
> Reporter: clebert suconic
>
> I have a need to create a special Message on Artemis, that will only parse
> the Header and send everything else as a byte array.
> Instead of duplicating the TLS logic, I would like to move this to its own
> class so it could be reused.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
