[
https://issues.apache.org/jira/browse/PROTON-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900222#comment-15900222
]
ASF GitHub Bot commented on PROTON-1345:
----------------------------------------
GitHub user kgiusti opened a pull request:
https://github.com/apache/qpid-proton/pull/97
PROTON-1345: update setup.py.in with libuv and cmake source list
Had to update the setup.py.in file with Alan Conway's libuv/proactor stuff.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kgiusti/qpid-proton PROTON-1345
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/97.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #97
----
commit 280877fc812ca7bfcf3d717fb409f0b04f7ffacc
Author: Kenneth Giusti <[email protected]>
Date: 2017-03-07T21:32:18Z
PROTON-1345: update setup.py.in with libuv and cmake source list
----
> [python] Avoid hardcoding the list of C files to be compiled in setup.py
> ------------------------------------------------------------------------
>
> Key: PROTON-1345
> URL: https://issues.apache.org/jira/browse/PROTON-1345
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
> Affects Versions: 0.15.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Fix For: 0.18.0
>
>
> Remove the hardcoded list of C source files in the setup.py file. It's easy
> to forget to update this list, and debugging the resulting tox build failure
> is tricky.
> Instead have the setup.py discover all the necessary C source files using an
> regex. Add an explicit blacklist for those C source files that shouldn't be
> built by the setup.py process (if there actually is any).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
