----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57392/#review168296 -----------------------------------------------------------
Ship it! Ship It! - Andrew Stitcher On March 8, 2017, 9:01 a.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57392/ > ----------------------------------------------------------- > > (Updated March 8, 2017, 9:01 a.m.) > > > Review request for qpid, Andrew Stitcher and Cliff Jansen. > > > Bugs: QPID-7693 > https://issues.apache.org/jira/browse/QPID-7693 > > > Repository: qpid-cpp > > > Description > ------- > > This avoids leaking a protoype socket for every client SslSocket created. (I > assume the prototype is still leaked for the server case, but since the > broker only closes the socket it listens on when shutting down that has much > less impact). This change just distinguishes sockets used for listening on > from those used for connecting. > > > Diffs > ----- > > src/qpid/sys/ssl/SslSocket.h 733a47a > src/qpid/sys/ssl/SslSocket.cpp 731151c > > > Diff: https://reviews.apache.org/r/57392/diff/2/ > > > Testing > ------- > > > Thanks, > > Gordon Sim > >
