Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/150#discussion_r107394882
  
    --- Diff: src/router_core/forwarder.c ---
    @@ -704,6 +704,16 @@ bool qdr_forward_link_balanced_CT(qdr_core_t     *core,
             out_link->link_type      = QD_LINK_ENDPOINT;
             out_link->link_direction = qdr_link_direction(in_link) == 
QD_OUTGOING ? QD_INCOMING : QD_OUTGOING;
             out_link->admin_enabled  = true;
    +        if (in_link->terminus_addr) {
    --- End diff --
    
    Why is this necessary?  It looks like you are ensuring that both connected 
links have their own copy of the terminus name.  However, in the agent code, 
you get the terminus name from either the direct link or the connected link.  
Isn't it sufficient to have the terminus name in only one of the connected 
links?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to