[ 
https://issues.apache.org/jira/browse/DISPATCH-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936175#comment-15936175
 ] 

ASF GitHub Bot commented on DISPATCH-357:
-----------------------------------------

Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/150#discussion_r107394882
  
    --- Diff: src/router_core/forwarder.c ---
    @@ -704,6 +704,16 @@ bool qdr_forward_link_balanced_CT(qdr_core_t     *core,
             out_link->link_type      = QD_LINK_ENDPOINT;
             out_link->link_direction = qdr_link_direction(in_link) == 
QD_OUTGOING ? QD_INCOMING : QD_OUTGOING;
             out_link->admin_enabled  = true;
    +        if (in_link->terminus_addr) {
    --- End diff --
    
    Why is this necessary?  It looks like you are ensuring that both connected 
links have their own copy of the terminus name.  However, in the agent code, 
you get the terminus name from either the direct link or the connected link.  
Isn't it sufficient to have the terminus name in only one of the connected 
links?


> Address field is empty for link routed links in the qdstat "links" output
> -------------------------------------------------------------------------
>
>                 Key: DISPATCH-357
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-357
>             Project: Qpid Dispatch
>          Issue Type: Bug
>    Affects Versions: 0.6.0
>            Reporter: Paolo Patierno
>            Assignee: Ganesh Murthy
>             Fix For: 0.8.0
>
>         Attachments: qdstat_links.txt
>
>
> I have a router with a link routed link for address "my_queue" configured (in 
> both directions in and out).
> Executing "qdstat -l", it doesn't show me the address name; the "addr" field 
> is empty.
> Attached you can find the file with output.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to