[ 
https://issues.apache.org/jira/browse/QPID-7630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937709#comment-15937709
 ] 

Andrew Stitcher commented on QPID-7630:
---------------------------------------

So I think the consensus is:

* Rename the current ENABLE_WARNINGS flag to ENABLE_WARNING_ERROR (this is 
consistent with the name in proton-c).
* Change the behaviour of the flag so that it only stops warnings being treated 
as errors, but still displays warnings.
This is in line with the same functionality in the proton-c build system.

> Add a CMake switch to allow -Werror to be switched off
> ------------------------------------------------------
>
>                 Key: QPID-7630
>                 URL: https://issues.apache.org/jira/browse/QPID-7630
>             Project: Qpid
>          Issue Type: Improvement
>          Components: C++ Broker, C++ Client
>    Affects Versions: qpid-cpp-1.36.0, qpid-cpp-1.37.0
>         Environment: GNU compilers
>            Reporter: Chris Richardson
>            Assignee: Justin Ross
>              Labels: patch
>             Fix For: qpid-cpp-1.38.0
>
>         Attachments: 1.36.0-disable-warnings-as-errors-switch.patch
>
>
> It could be useful in some situations (eg: when packaging/installing) to be 
> able to disable warnings as errors in the build. This is the recommendation 
> for instance of the Gentoo packaging guide 
> (https://devmanual.gentoo.org/ebuild-writing/common-mistakes, section 
> "-Werror compiler flag not removed").
> See attached patch.
>  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to