----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57887/ -----------------------------------------------------------
Review request for qpid, Ganesh Murthy and Ted Ross. Repository: qpid-dispatch Description ------- (Also on https://github.com/apache/qpid-dispatch/compare/master...alanconway:proactor-prune?expand=1 ) DISPATCH-309: Clean up dead code - qd_bind_state_t set but never used - threads_active set but never used - is_connector set but never used - pyflakes errors in system_tests_*manage*.py - mark private connection_manager.c functions as static NO-JIRA: Remove redundant SSL versions of tests Removed redundant SSL tests in system_tests_qdmanage and system_tests_two_routers. The tests take a long time to run and SSL is covered elsewhere. DISPATCH-309: Get rid of ssl_profile reference counts Copy SSL profile date at the time the connector or listener is configured, so that it is safe to delete an SSL profile even if there are connectors/listeners that used it. Simplifying the lifecycle, getting rid of reference counts and removing the user restrictions on removing SSL profiles seems to justify the small memory duplication for the SSL profile data. This means you cannot change an SSL profile and have the changes applied on the next retry of a connector, but that seems like it would be an insane and thread-unsafe thing to do anyway. Diffs ----- include/qpid/dispatch/connection_manager.h 28a944c08b3a4221cfdc0ed657ea9d98504c3e55 include/qpid/dispatch/server.h b9c1771266644bae583dcd62907a20363ef9646e python/qpid_dispatch_internal/management/agent.py 7f50cb838ba65e84efd919fd445a0cf74dbcdcfd src/connection_manager.c be406d64d21347e11c5ee0a5c55c44b6981b3fc8 src/server.c 8d2178cbc22a3c33b4b9866d6b36a21d69b5bd9b src/server_private.h 576b5eccb7691d8f793cb5929963ae2c986f5d98 tests/system_tests_management.py 19f69fcaeda16c76b58feb47b90c8a0516be3df5 tests/system_tests_qdmanage.py 120e95995d3ac0932c13a61e74bd109fc538620f tests/system_tests_sasl_plain.py a180d809989e5f65ea2e6472f8a476d6d73e7afd tests/system_tests_two_routers.py db82838a2acd507f46fdb9c9c84a7efc57739bbe Diff: https://reviews.apache.org/r/57887/diff/1/ Testing ------- Passes ctest, total test time reduced by about 30%. There are still some unreasonably long tests, esp. system_tests_two_routers Thanks, Alan Conway
