[
https://issues.apache.org/jira/browse/DISPATCH-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15939073#comment-15939073
]
Ganesh Murthy commented on DISPATCH-627:
----------------------------------------
Hi Adel,
I looked at your patch
{noformat}
+ def on_timer_task(self, event):
+ # As long as we are receiving messages, restart the timeout
+ if self.n_sent == self.parent.n_sent and self.n_received ==
self.parent.n_received and self.n_settled == self.parent.n_settled:
+ self.parent.timeout()
+ else:
+ self.n_sent = self.parent.n_sent
+ self.n_received = self.parent.n_received
+ self.n_settled = self.parent.n_settled
+ if not self.parent.check_if_done():
+ event.reactor.schedule(BatchTimeout.TIMEOUT_MILLIS, self)
{noformat}
if {noformat}if not self.parent.check_if_done():{noformat} always returns true
(due to the router having a real bug), this test will keep scheduling
additional timeouts forever.
> Implement a more systematic batch timeout test to avoid having low timeout
> value fail the test on slow machines
> ---------------------------------------------------------------------------------------------------------------
>
> Key: DISPATCH-627
> URL: https://issues.apache.org/jira/browse/DISPATCH-627
> Project: Qpid Dispatch
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Adel Boutros
> Assignee: Ganesh Murthy
> Fix For: 0.8.0
>
> Attachments:
> 0001-Implement-a-more-systematic-batch-timeout-test-to-av.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
