[
https://issues.apache.org/jira/browse/PROTON-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943408#comment-15943408
]
ASF GitHub Bot commented on PROTON-1408:
----------------------------------------
Github user astitcher commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/99#discussion_r108192064
--- Diff: proton-c/src/core/transport.c ---
@@ -1620,12 +1622,12 @@ static int pn_scan_error(pn_data_t *data,
pn_condition_t *condition, const char
}
/*
- This operator, copied from code for the qpid cpp broker, gives the
correct
+ This operator, inspired by code for the qpid cpp broker, gives the
correct
result when comparing sequence numbers implemented in a signed integer
type.
*/
-static bool sequence_less_than ( pn_sequence_t a, pn_sequence_t b )
+static bool sequence_cmp ( pn_sequence_t a, pn_sequence_t b )
--- End diff --
This should be ```inline```
> long-lived connections suffer large performance hit after many messages
> -----------------------------------------------------------------------
>
> Key: PROTON-1408
> URL: https://issues.apache.org/jira/browse/PROTON-1408
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Reporter: michael goulish
> Assignee: Alan Conway
> Attachments: jira_proton_1408_reproducer.tar.gz
>
>
> In long-running soak tests, in which connections are never taken down, I am
> seeing a sudden & severe performance degradation when the number of messages
> over the connection reaches about 6.4 billion.
> This is happening in tests with two senders, two receivers & one router
> intermediating.
> I have tried C libUV clients as well as CPP clients. Behavior is not
> identical, but I see sudden performance drop, ie. 8x throughput decrease or
> worse, in both cases.
> Alan / Ted / Ken see an issue in use of improper comparison logic in
> pn_do_disposition(), in transport.c . I am trying to prove this now.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
