Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/101
Disagree. IMO it is good design for all return values of a failing call to
be set to known failure indicators provided a) there are such indicators, b)
it is not costly to do so, and c) it is unlikely there was valuable data in
them before call. Provided the API doc is clear that the value will always be
set (to "" in an error) that seems to me more robust than leaving random data
lying around.
I agree the tests are poorly written for not checking the return value but
I think the more robust behavior leads to less support calls.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
