[
https://issues.apache.org/jira/browse/PROTON-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951005#comment-15951005
]
ASF GitHub Bot commented on PROTON-1453:
----------------------------------------
GitHub user kgiusti opened a pull request:
https://github.com/apache/qpid-proton/pull/102
NO-JIRA: revert temporary workaround for PROTON-1453
Looks like the fix for PROTON-1453 resolves the problems travis hit for the
tox tests. This change reverts just the change where the travis config
filtered out py33 and py34.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kgiusti/qpid-proton revert-tox
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/102.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #102
----
commit 747c2e1ab47c65b6ee23b9b5b41080c8e7fa2b9c
Author: Kenneth Giusti <[email protected]>
Date: 2017-03-31T14:10:22Z
NO-JIRA: revert temporary workaround for PROTON-1453
----
> pn_ssl_get_{protocol|cypher}_name() may segfault when called by bindings
> ------------------------------------------------------------------------
>
> Key: PROTON-1453
> URL: https://issues.apache.org/jira/browse/PROTON-1453
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Affects Versions: 0.17.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Fix For: 0.18.0
>
>
> the pn_ssl_get_password/cipher_name method takes a target buffer and length
> and if the name is known it is copied to the buffer (null terminated) and
> true is returned.
> However if the name is not known (not yet present) the method returns false
> and leaves the buffer untouched.
> This is fine for correctly behaving C programs, but the swig generated code
> always assumes the output buffer contains a properly terminated string
> whether or not the return value is true. The swigged code unconditionally
> calls strlen() on the returned buffer.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
