[ 
https://issues.apache.org/jira/browse/PROTON-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959241#comment-15959241
 ] 

Kale Blankenship commented on PROTON-1450:
------------------------------------------

I'm not the author of that patch, my apologies if my phrasing implied 
otherwise. I found it while researching AMQP 1.0 support for Go. Since it's MIT 
licensed I figured it might be a useful reference for this issue.

I am working on a pure Go AMQP 1.0 client implementation (hobby project, 
pre-alpha). Currently I'm representing filters as `map[Symbol]interface{}`, as 
you suggested. I can only find a reference to filters on the source 
(http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#type-source),
 not the target 
(http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#type-target),
 but perhaps I've misunderstood something.

Your AnnotationKey proposal looks to be a good solution. I was considering 
using `map[interface{}]interface{}` but only allowing clients of the library to 
set annotations via type safe function arguments. Something similar to `func 
AnnotationSymbol(key string, value interface{}) OptionFunc`/`func 
AnnotationUlong(key uint64, value interface{}) OptionFunc`. Although, since 
ulong keys are reserved it may be nice to have specific function arguments for 
each of the reserved annotations and a single `func Annotation(key string, 
value interface{}) OptionFunc` for "x-" annotations.

> Add Filter LinkOption to Electron API
> -------------------------------------
>
>                 Key: PROTON-1450
>                 URL: https://issues.apache.org/jira/browse/PROTON-1450
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: go-binding
>            Reporter: Kale Blankenship
>            Assignee: Alan Conway
>
> There doesn't appear to be a way to set filters with the current Go bindings. 
> Microsoft's Event Hubs use filters to indicate the starting offset of 
> messages 
> (http://azure.github.io/amqpnetlite/articles/azure_eventhubs.html#filter). 
> Without this option it would be difficult to properly use the bindings with 
> Event Hubs.
> There is a wrapper which patches the bindings to provide the functionality 
> here: https://github.com/recobe182/gohub. Though I am not familiar enough 
> with Qpid to determine if the patch is reasonable.
> Thank you for considering this request and creating/maintaining this project!



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to