Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-jms/pull/7#discussion_r116048356
--- Diff:
qpid-jms-examples/src/main/java/org/apache/qpid/jms/example/Client.java ---
@@ -0,0 +1,106 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ */
+package org.apache.qpid.jms.example;
+
+import javax.jms.Connection;
+import javax.jms.ConnectionFactory;
+import javax.jms.DeliveryMode;
+import javax.jms.Destination;
+import javax.jms.ExceptionListener;
+import javax.jms.JMSException;
+import javax.jms.Message;
+import javax.jms.MessageConsumer;
+import javax.jms.MessageProducer;
+import javax.jms.Session;
+import javax.jms.TemporaryQueue;
+import javax.jms.TextMessage;
+import javax.naming.Context;
+import javax.naming.InitialContext;
+
+public class Client {
+ private static final int DELIVERY_MODE = DeliveryMode.NON_PERSISTENT;
+
+ public static void main(String[] args) throws Exception {
+ try {
+ // The configuration for the Qpid InitialContextFactory has
been supplied in
+ // a jndi.properties file in the classpath, which results in
it being picked
+ // up automatically by the InitialContext constructor.
+ Context context = new InitialContext();
+
+ ConnectionFactory factory = (ConnectionFactory)
context.lookup("myFactoryLookup");
+ Destination queue = (Destination)
context.lookup("myQueueLookup");
+
+ Connection connection =
factory.createConnection(System.getProperty("USER"),
System.getProperty("PASSWORD"));
+ connection.setExceptionListener(new MyExceptionListener());
+ connection.start();
+
+ Session session = connection.createSession(false,
Session.AUTO_ACKNOWLEDGE);
+
+ //Creates a message and temporary queue to send to and from.
+ int random = (int) (Math.random()*3);
+ TextMessage messageToBeSent;
+ if (random == 0) {
+ messageToBeSent = session.createTextMessage("first example
message");
+ } else if (random == 1) {
+ messageToBeSent = session.createTextMessage("second
example message");
+ } else {
+ messageToBeSent = session.createTextMessage("third example
message");
+ }
+
+ TemporaryQueue tempQueue = session.createTemporaryQueue();
+ messageToBeSent.setJMSReplyTo(tempQueue);
+ MessageProducer messageProducer =
session.createProducer(queue);
+
+ //Send the message
+ messageProducer.send(messageToBeSent, DELIVERY_MODE,
Message.DEFAULT_PRIORITY, Message.DEFAULT_TIME_TO_LIVE);
+ System.out.println("[CLIENT] The message with text \"" +
messageToBeSent.getText() +"\" has been sent.");
+
+ MessageConsumer messageConsumer =
session.createConsumer(tempQueue);
+
+ //Receive the server response
+ TextMessage receivedMessage = (TextMessage)
messageConsumer.receive(1000);
+ if (receivedMessage != null) {
+ System.out.println("[CLIENT] Response from server
received.");
+ } else {
+ System.out.println("[CLIENT] Response not received within
timeout, stopping.");
+ }
+
+ //Display response and close client.
+ System.out.println("[CLIENT] Here is the interpreted
message:\n" + receivedMessage.getText() + "\n[CLIENT] Quitting Client.");
--- End diff --
I'd probably just print a single line showing the response text, and
optionally the request text. E.g. other exampels show a line with "\<lowercase
request\> --> \<uppercase response\>" style output.
I suggested a loop above to send multiple requests. You could also put the
receive call in the loop, and that way it would act as more of a synchronous
send-request ->receive-response example, which is commonly how this will be
used.
Seperately, the receivedMessage object is referenced here even after it
might have been found to be null earlier, which would throw a
NullPointerException. Moving the output process up to within the if statement
checking the response message will sort that out.
Although this would go away with the above suggestions, note that in the
existing code the use of "\n" in the println isn't desirable since it is
platform-specific. To ensure the output works consistently, you should either
use multiple println calls, or get the platform-specific line separator (e.g.
System.lineSeparator();) and use it rather than hard coding \n in the string.
Alternatively, formatter strings can do the proper separator replacement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
