----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59340/#review175259 -----------------------------------------------------------
I like the idea of hiding the implementation, but not if it requires coupling the C++ binding to the internals of proton-c. I've not looked deeply into these changes, but if you need that coupling then you may need to add to the proton-c API. proton-c/bindings/cpp/CMakeLists.txt Lines 24 (patched) <https://reviews.apache.org/r/59340/#comment248709> I'm strongly against making the cpp binding depend on the internals of proton-c - Andrew Stitcher On May 17, 2017, 3:34 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59340/ > ----------------------------------------------------------- > > (Updated May 17, 2017, 3:34 p.m.) > > > Review request for qpid, Andrew Stitcher and Cliff Jansen. > > > Repository: qpid-proton-git > > > Description > ------- > > PROTON-1288: c++ hide proton::message implementation details > > No extra allocations, hide extra book-keeping types in extra storage > allocated with the pn_message_t. > > > Diffs > ----- > > proton-c/bindings/cpp/CMakeLists.txt > 0cc402478c993f6cc9f58258acb6978cea44c347 > proton-c/bindings/cpp/include/proton/message.hpp > 85ccff6aa7afa238a146e899f9ba67cbcd680e7a > proton-c/bindings/cpp/src/message.cpp > eecfa3b51db59c97c82d0b582c33419e2ad46707 > proton-c/src/core/max_align.h PRE-CREATION > proton-c/src/core/message-internal.h PRE-CREATION > proton-c/src/core/message.c f2fb20e8b025807a9306d59746cf27818ca01345 > > > Diff: https://reviews.apache.org/r/59340/diff/1/ > > > Testing > ------- > > > Thanks, > > Alan Conway > >
