[ 
https://issues.apache.org/jira/browse/QPID-7723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020908#comment-16020908
 ] 

ASF subversion and git services commented on QPID-7723:
-------------------------------------------------------

Commit 1172f8629f5b781044ba9e78a4a5ec0f7b2becd7 in qpid-broker-j's branch 
refs/heads/6.1.x from [~lorenz.quack]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=1172f86 ]

Revert "QPID-7723: Optimize evaluation of metadata storable size for AMQP 0-10"

This reverts commit 7772251c1534c5c6ac1d168ee16f019206d60355.


> [0-10] Re-encoding of the 0-10 message during computation of 
> updateStatsOnEnqueue causes performance slow down
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-7723
>                 URL: https://issues.apache.org/jira/browse/QPID-7723
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: qpid-java-broker-7.0.0
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: qpid-java-6.0.7, qpid-java-broker-7.0.0, qpid-java-6.1.3
>
>         Attachments: hotspot_comparison.tar.bz2
>
>
> We are seeing a slowdown in the Java Broker for the 0-10 protocol since 
> February 2017.  Investigation with JProfiler is pointing to the introduction 
> of the ring queue feature as being a possible cause.   The performance drop 
> is most apparent with on the transient profiles, where the drop is around 
> ~2-3%.
> The problem is the new call to MessageMetaData_0_10#getStorableSize made from 
> AbstractQueueEntryList#updateStatsOnEnqueue. On the 0-10 path, this causes 
> the header delivery properties/message properties/non standard delivery 
> properties to be encoded in order to compute the store size.  This encoding 
> step is separate to the encoding step that takes place when the message is 
> sent to a consumer.  The up shot is that the headers for a transient message 
> that is not flown to disk are now encoded twice rather than once.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to