[
https://issues.apache.org/jira/browse/QPID-7731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024535#comment-16024535
]
Keith Wall commented on QPID-7731:
----------------------------------
Alex
A couple of comments:
# PortManager's new methods FPs are in terms of the {{HttpPortImpl}} rather
than the interface. This seems to be unnecessary.
# org.apache.qpid.server.model.port.HttpPort#getDesiredNumberOfAcceptors
derived attributes cannot be set, so the advice "You can set it to (a) negative
value" is wrong. I'd add "see: " +{{PORT_HTTP_NUMBER_OF_ACCEPTORS}} and move
the "You can..." part of the description to the context variable's description
where it better belongs. I would rephrase to avoid the third-person 'you can'
too e.g. "Number of acceptors, if negative the number of acceptors is
determined by Jetty"
# org/apache/qpid/server/management/plugin/HttpManagement.java:519 does the
new logging include the remote endpoint information?? I did not retest but
from my experiments, I thought we would need to include info from {{event}} too.
# in description for
org.apache.qpid.server.model.port.HttpPort#getAcceptBacklogSize "accepts" to
"accept"
# Make the Jetty-Server-Thread daemon
> Upgrade to Jetty 9.4
> --------------------
>
> Key: QPID-7731
> URL: https://issues.apache.org/jira/browse/QPID-7731
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: qpid-java-broker-7.0.0
>
> Attachments:
> 0001-QPID-7731-HTTP-Management-Upgrade-Jetty-to-9.4.patch,
> 0001-QPID-7731-HTTP-Management-Upgrade-Jetty-to-9.4.patch,
> 0001-QPID-7731-HTTP-Management-Upgrade-Jetty-to-9.4.patch
>
>
> The version of Jetty used by the Java Broker is v8.1. This is now marked as
> EOL by the Jetty development team. We should upgrade to Jetty v9.4 (an
> option now we are on Java 8). The Jetty API has changed substantially so
> the HTTP Management is probably going to need a deep rewrite.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
