[ 
https://issues.apache.org/jira/browse/DISPATCH-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024694#comment-16024694
 ] 

ASF GitHub Bot commented on DISPATCH-780:
-----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/qpid-dispatch/pull/164


> When link is disallowed due to target/source name it should not return 
> amqp:resource-limit-exceeded
> ---------------------------------------------------------------------------------------------------
>
>                 Key: DISPATCH-780
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-780
>             Project: Qpid Dispatch
>          Issue Type: Bug
>            Reporter: Jakub Scholz
>             Fix For: 1.0.0
>
>
> It seems that today, when link creation is denied by the policy, it always 
> returns {{amqp:resource-limit-exceeded}} error. That is valid when the link 
> is rejected because exceeding the number of senders / receivers specified in 
> the policy. However, this doesn't seem to be the correct error when the link 
> creation is not allowed because the target/source name is not allowed. In 
> such case, {{amqp:unauthorized-access}} seems to be more appropriate.
> Additionally, it looks like in {{policy.c}} the function 
> {{qd_policy_approve_amqp_sender_link}} calls on several places 
> {{_qd_policy_deny_amqp_receiver_link}} instead of 
> {{_qd_policy_deny_amqp_sender_link}}.
> I will try to provide some PR with suggested fix.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to