[
https://issues.apache.org/jira/browse/QPID-7649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029259#comment-16029259
]
Keith Wall edited comment on QPID-7649 at 5/30/17 10:59 AM:
------------------------------------------------------------
Currently, the consumer target created by the sending link does not know that
it "MUST NOT send any new deliveries" (2.7.3 - attach), so it will violate the
spec and the peer will be obliged to detach. We need a way to tell the
consumer target not to deliver anything (perhaps an additional clause
({{ConsumerTarget_1_0#allocateCredit}}) to consider that incomplete-unsettled
flag.
It is not clear to me if "Note that if this flag is set to true then the
endpoints MUST detach and reattach at least once in order to send new
deliveries." means that the Broker is required to send a detach after
actioning the unsettled map.
Separately, it strikes me we could defer the implementation of this part of the
spec for a later release. If we were to take this approach, the minimum change
would be to fail gracefully (i.e. close the connection) if we were to encounter
a peer that passed a {{incomplete-unsettled=true}}
was (Author: k-wall):
Currently, the consumer target created by the sending link does not know that
it "MUST NOT send any new deliveries" (2.7.3 - attach), so it will violate the
spec and the peer will be obliged to detach. We need a way to tell the
consumer target not to deliver anything (perhaps an additional clause
({{ConsumerTarget_1_0#allocateCredit}}) to consider that incomplete-unsettled
flag.
It is not clear to me if "Note that if this flag is set to true then the
endpoints MUST detach and reattach at least once in order to send new
deliveries." means that the Broker is required to detach after actioning the
unsettled map.
> [Java Broker] Support AMQP 1.0 Attach with incomplete-unsettled=true
> --------------------------------------------------------------------
>
> Key: QPID-7649
> URL: https://issues.apache.org/jira/browse/QPID-7649
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Reporter: Lorenz Quack
> Fix For: qpid-java-broker-7.0.0
>
>
> The AMQP 1.0 spec (2.7.3) allows to send an Attach with an incomplete
> {{unsettled}} map together with {{incomplete-unsettled=true}}. This is useful
> in cases where the unsettled map is too large to fit in a single frame.
> We currently do not respect this, violating the spec.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
