----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59638/#review176417 -----------------------------------------------------------
Ship it! Ship It! - Cliff Jansen On May 30, 2017, 4:48 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59638/ > ----------------------------------------------------------- > > (Updated May 30, 2017, 4:48 p.m.) > > > Review request for qpid, Andrew Stitcher and Cliff Jansen. > > > Repository: qpid-proton-git > > > Description > ------- > > pn_proactor_interrupt() will often be used from signal handlers so must be > async-signal-safe. Updated the documentation and modified the implementations > of pn_proactor_interrupt() to use only async-signal-safe calls, no locks. > > > Diffs > ----- > > examples/c/proactor/broker.c 7d95e7fc49e53cc5e36c62b814d39287005eb59f > proton-c/include/proton/proactor.h 861afbed22df6cb6aa9e18c15cdb7cd9ed64eede > proton-c/src/proactor/epoll.c 7490ecdcaf984ec33d9b26c6f0357c6de2e09d0f > proton-c/src/proactor/libuv.c cf7a31b5711f207541c9e832b06bb13e7051ab69 > > > Diff: https://reviews.apache.org/r/59638/diff/1/ > > > Testing > ------- > > proactor self-tests on epoll and libuv proactor > > > Thanks, > > Alan Conway > >
