[
https://issues.apache.org/jira/browse/QPID-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046462#comment-16046462
]
Alex Rudyy commented on QPID-7782:
----------------------------------
The changes in {{org.apache.qpid.server.protocol.v1_0.AMQPConnection_1_0Impl}}
and new tests look good to me. However, I got some suggestions about further
test improvements:
* * {{org.apache.qpid.tests.protocol.v1_0.Response}}.
I think we can generalize response class as below
{code}
public interface Response<T>
{
T getBody();
}
{code}
That should remove some of the boilerplate code in
{{org.apache.qpid.tests.protocol.v1_0.FrameTransport}}
I attached a patch with the generalization changes.
* Configuring password and SASL mechanisms and disabling SASL tests.
One of the goals of the protocol framework was to be be able to run it against
different brokers. It could be that not all brokers can support PLAIN or
CRAM-MD5. I think we need to add a way to disable the tests if broker does not
support some of the test required features. It seems that existing tests
require Broker to support at least 3 SASL mechanisms: ANONYMOUS, CRAM-MD5 and
PLAIN. I am happy to postpone this work for later but it something we need to
consider doing at some point in time.
* Unused method
{{org.apache.qpid.tests.protocol.v1_0.FrameTransport#assertChannelClosed}}
> [Java Broker] [AMQP1.0] NPE on connection when no default virtualhost exists
> ----------------------------------------------------------------------------
>
> Key: QPID-7782
> URL: https://issues.apache.org/jira/browse/QPID-7782
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Reporter: Lorenz Quack
> Fix For: qpid-java-broker-7.0.0
>
> Attachments:
> 0001-QPID-7782-Tests-Generalise-test-framework-class-org..patch
>
>
> The following NPE was encountered on connection when no default virtualhost
> existed on the Broker and no virtualhost specified by the client. Broker did
> not crash.
>
> {noformat}
> 2017-05-12 15:46:46,988 WARN [IO-/127.0.0.1:37166]
> (o.a.q.s.p.v.f.FrameHandler) - Unexpected exception handling frame
> java.lang.NullPointerException: null
> at
> org.apache.qpid.server.protocol.v1_0.Session_1_0.getPrimaryDomain(Session_1_0.java:1608)
> at
> org.apache.qpid.server.protocol.v1_0.Session_1_0.<init>(Session_1_0.java:185)
> at
> org.apache.qpid.server.protocol.v1_0.AMQPConnection_1_0Impl.receiveBegin(AMQPConnection_1_0Impl.java:625)
> at
> org.apache.qpid.server.protocol.v1_0.type.transport.Begin.invoke(Begin.java:229)
> at
> org.apache.qpid.server.protocol.v1_0.AMQPConnection_1_0Impl.receive(AMQPConnection_1_0Impl.java:320)
> at
> org.apache.qpid.server.protocol.v1_0.framing.FrameHandler.parse(FrameHandler.java:176)
> at
> org.apache.qpid.server.protocol.v1_0.AMQPConnection_1_0Impl$9.run(AMQPConnection_1_0Impl.java:1235)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> org.apache.qpid.server.protocol.v1_0.AMQPConnection_1_0Impl.received(AMQPConnection_1_0Impl.java:1208)
> at
> org.apache.qpid.server.transport.MultiVersionProtocolEngine.received(MultiVersionProtocolEngine.java:130)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.processAmqpData(NonBlockingConnection.java:593)
> at
> org.apache.qpid.server.transport.NonBlockingConnectionPlainDelegate.processData(NonBlockingConnectionPlainDelegate.java:58)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.doRead(NonBlockingConnection.java:483)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.doWork(NonBlockingConnection.java:270)
> at
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:124)
> at
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:563)
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:354)
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:97)
> at
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:521)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
