[
https://issues.apache.org/jira/browse/QPID-7815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomas Vavricka updated QPID-7815:
---------------------------------
Attachment: 0001-QPID-7815-Reject-policy-type.patch
Hi Lorenz,
thanks for review, I tried to fix the issues.
* I think {{AccessController.getContext()}} cannot be cached because when
{{getContext()}} is called it takes a "snapshot" of the current calling context
* I was inspired by Qpid C++ Broker. C++ broker is using
{{amqp:precondition-failed}} for AMQP 1.0 protocol. I changed it to
{{amqp:resource-limit-exceeded}}
* Closing due to rejection is done in IO thread on all code paths
* When i use {{AMQChannel#closeChannel}}, test for 0-9 in
{{QueuePolicyTest#testRejectPolicy}} is failing. I left there method
{{close()}} for now
* I checked it with qpid-jms 1.0 client (0.11.1) and there was correctly thrown
exception in client (without closing connection). I fixed reject queue policy
tests for 0-8 and 1.0, but I have to close connection as well to pass the
tests. btw. ring policy test is still failing in AMQP 1.0 protocol, but I think
this is not connected to reject queue policy
I saw you already created topic in [email protected].. I tried to apply those changes
* no {{Queue#getNewestEntry()}}
* no loop in policy handler
* message is deleted only when session principal is present
I attached new patch where are applied changes from patch you sent as well.
> Reject policy type
> ------------------
>
> Key: QPID-7815
> URL: https://issues.apache.org/jira/browse/QPID-7815
> Project: Qpid
> Issue Type: New Feature
> Components: Java Broker
> Affects Versions: qpid-java-broker-7.0.0
> Reporter: Tomas Vavricka
> Assignee: Lorenz Quack
> Labels: policy-type, queue, reject
> Fix For: qpid-java-broker-7.0.0
>
> Attachments:
> 0001-QPID-7815-Java-Broker-Enable-QueuePolicyTests-on-all.patch,
> 0001-QPID-7815-Reject-policy-type.patch
>
>
> It would be good if Java Broker will support reject policy.
> Reject policy - reject incoming message(s) when queue capacity is reached
> Queue capacity can be defined by maximum count of message and maximum size of
> messages (including header).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
