[
https://issues.apache.org/jira/browse/QPID-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057412#comment-16057412
]
Alex Rudyy commented on QPID-7820:
----------------------------------
I reviewed the changes made in commit [
https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=b36c718 ]. Here
are my comments.
* The WebSocketTest expects that tested broker supports the websocket transport
(with anonymous authentication) by default. Taking that not all tested broker
might support WS, the BrokerAdmin needs a method to check whether WS port is
supported and test setUp should call assumeThat() to verify the support
(something like {{ boolean isSupported(PortType portType)}}
* Unused constructor parameter {{uri}} in
{{WebSocketFrameTransport.WebSocketClientHandler#WebSocketClientHandler}} needs
to be removed
> Extend AMQP 1.0 protocol tests to support web socket tests too
> --------------------------------------------------------------
>
> Key: QPID-7820
> URL: https://issues.apache.org/jira/browse/QPID-7820
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Tests
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: qpid-java-broker-7.0.0
>
>
> Extend AMQP 1.0 protocol tests to support web socket tests too
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
