[ 
https://issues.apache.org/jira/browse/DISPATCH-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058140#comment-16058140
 ] 

ASF GitHub Bot commented on DISPATCH-788:
-----------------------------------------

Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/169#discussion_r123356056
  
    --- Diff: src/router_core/transfer.c ---
    @@ -412,14 +412,41 @@ static void 
qdr_delete_delivery_internal_CT(qdr_core_t *core, qdr_delivery_t *de
         free_qdr_delivery_t(delivery);
     }
     
    +static bool qdr_delivery_has_peer_CT(qdr_delivery_t *dlv)
    +{
    +    if (!dlv->peer && DEQ_SIZE(dlv->peers) == 0)
    --- End diff --
    
    You could do this more elegantly like this:
        return dlv->peer || DEQ_SIZE(dlv->peers) > 0;



> Create peer linkage for presettled deliveries so we can use this to handle 
> muticast dispositions
> ------------------------------------------------------------------------------------------------
>
>                 Key: DISPATCH-788
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-788
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>          Components: Container
>    Affects Versions: 0.8.0
>            Reporter: Ganesh Murthy
>            Assignee: Ganesh Murthy
>             Fix For: 1.0.0
>
>
> Right now peer delivieries are not created for presettled messages. Create 
> peers for presettled messages so that this feature can be used to implement 
> several features like message streaming, handling multicast dispositions etc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to