Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/172#discussion_r126155671
--- Diff: include/qpid/dispatch/buffer.h ---
@@ -32,10 +32,14 @@ typedef struct qd_buffer_t qd_buffer_t;
DEQ_DECLARE(qd_buffer_t, qd_buffer_list_t);
+extern size_t BUFFER_SIZE;
+extern size_t MAX_BUFFER_LENGTH;
+
/** A raw byte buffer .*/
struct qd_buffer_t {
DEQ_LINKS(qd_buffer_t);
unsigned int size; ///< Size of data content
+ unsigned int fanout; // The number of receivers for this buffer
--- End diff --
Q: Why record fanout per-buffer? Fanout is per-message and buffers can be
re-used with different fanouts in different messages. Can we avoid duplicating
the fanout value from the message onto all its buffers? Maybe not - just
wondering, it seems out of place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
