[
https://issues.apache.org/jira/browse/QPIDJMS-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091460#comment-16091460
]
ASF GitHub Bot commented on QPIDJMS-294:
----------------------------------------
Github user gemmellr commented on the issue:
https://github.com/apache/qpid-jms/pull/9
Looks good. I gave things a try with the changes from PROTON-1486 (now
pushed) against Dispatch and the C++ broker, which continue to send the
explicit challange before the outcome rather than use the additional-data
field, all seemed well. I assumed you used the java broker and its related
changes on QPID-7787 so I skipped that.
On the unit testing, extracting a mechanism finder seems reasonable, can
probably do something simple with lambdas and/or method references to
essentially pass what its doing now.
I'll wait for proton-j 0.20.0 / PROTON-1486 to actually be available before
merging this since it isnt yet pressing and it saves master failing to compile
later once the snapshots aren't around.
> The SCRAM-SHA-* SASL mechanisms should verify the server final message if it
> is sent in the additional-data field of sasl-outcome
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: QPIDJMS-294
> URL: https://issues.apache.org/jira/browse/QPIDJMS-294
> Project: Qpid JMS
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Rob Godfrey
> Fix For: 0.24.0
>
>
> Currently the client will only verify the server final message if it is sent
> as an extra challenge in the sasl exchange.
> The client should also verify if the server final message is sent as
> additional-data on the sasl outcome (which is really the way this should
> always be sent).
> In order to do this PROTON-1486 will need fixing
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
