[
https://issues.apache.org/jira/browse/QPIDJMS-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096351#comment-16096351
]
Keith Wall commented on QPIDJMS-305:
------------------------------------
Doesn't AmqpProvider already keep a reference to the same AsyncResult
(org/apache/qpid/jms/provider/amqp/AmqpProvider.java:136)? It strikes me that
information hiding could be improved by not having the {{AsyncResult}} exposed
to {{AmqpSaslAuthenticator}} and instead turn
{{AmqpSaslAuthenticator#wasSuccessful()}} into something that would expose the
{{failureCause}}. AmqpProvider would then call AsyncResult#onSuccess/onFailure
directly (as it already does in other situations).
> Potential race on sasl authentication failures can throw wrong exception on
> connect
> -----------------------------------------------------------------------------------
>
> Key: QPIDJMS-305
> URL: https://issues.apache.org/jira/browse/QPIDJMS-305
> Project: Qpid JMS
> Issue Type: Bug
> Components: qpid-jms-client
> Affects Versions: 0.23.0
> Reporter: Timothy Bish
> Assignee: Timothy Bish
> Fix For: 0.24.0
>
>
> During the SASL authentication process there's a change that an error thrown
> from the handler code in the exchange phases can result the wrong exception
> being thrown from the connection create methods in the ConnectionFactory due
> to a race between asynchronous notifications and the exception thrown from
> the connect call.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
