Github user ChugR commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/177#discussion_r129305989
--- Diff: src/message.c ---
@@ -846,6 +853,8 @@ qd_message_t *qd_message()
}
ZERO(msg->content);
+ msg->content->receive_complete = false;
+ msg->content->discard = false;
--- End diff --
after ZEROing the content setting any value to 0 or false (seven places) is
a waste. Maybe change the assignments to asserts if you don't trust the ZERO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
