[
https://issues.apache.org/jira/browse/QPID-7874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111698#comment-16111698
]
Chris Richardson commented on QPID-7874:
----------------------------------------
While testing an alternative patch along the lines above, I noticed that the
"checkLink" method does not (as I originally thought) fail the operation if the
link does not become active - only if it is not created at all or is in an
error state (which does NOT include being in a disconnected state).
Example output from the existing qpid-route (with a broker on port 5672 and
nothing on 5674):
{quote}
$ qpid-route -v route add localhost:5672 localhost:5674 amq.direct key
Link state is Waiting
Creating inter-broker binding...
Bridge method returned: 0 OK
$ qpid-route link list
Host Port Transport Durable State Last Error
=============================================================================
localhost 5674 tcp N Waiting Connection refused
{quote}
Nevertheless I'll submit the now-rather-trivial PR (the effect of which is to
avoid the extra fetches of the link and 3 second wait for the link to come up)
and see what you think...
> qpid-route performs an unnecessary link check when adding routes
> ----------------------------------------------------------------
>
> Key: QPID-7874
> URL: https://issues.apache.org/jira/browse/QPID-7874
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: qpid-cpp-1.36.0
> Reporter: Chris Richardson
>
> Having connected to the destination broker (for "normal" routes) or source
> broker (for "src-local" routes), the qpid-route utility checks that the
> inter-broker link is active before configuring the new bridge. This check is
> not necessary since the bridge can still be created even if the network link
> is down. When the remote broker becomes accessible, the inter-broker link and
> the bridge will come up as expected.
> PR: https://github.com/apache/qpid-cpp/pull/5
> An alternative to simply removing the check might be to make it a
> configuration option.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
