[
https://issues.apache.org/jira/browse/PROTON-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120120#comment-16120120
]
ASF GitHub Bot commented on PROTON-1533:
----------------------------------------
Github user astitcher commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/115#discussion_r132225370
--- Diff: proton-c/bindings/php/CMakeLists.txt ---
@@ -34,7 +34,7 @@ list(APPEND SWIG_MODULE_cproton_EXTRA_DEPS
${CMAKE_SOURCE_DIR}/proton-c/include/proton/cproton.i
${PROTON_HEADERS}
)
-swig_add_module(cproton php ${CMAKE_CURRENT_SOURCE_DIR}/php.i)
+swig_add_library(cproton LANGUAGE php SOURCES
${CMAKE_CURRENT_SOURCE_DIR}/php.i)
--- End diff --
Not directly related to your change, but I think the
${CMAKE_CURRENT_SOURCE_DIR} is extraneous here and is different from all the
other uses of swig_add_library in the other bindings.
> Swig deprecation warnings with recent versions of cmake
> -------------------------------------------------------
>
> Key: PROTON-1533
> URL: https://issues.apache.org/jira/browse/PROTON-1533
> Project: Qpid Proton
> Issue Type: Bug
> Components: build
> Environment: Fedora 25, 26
> Cmake 3.8+
> Reporter: Justin Ross
> Assignee: Justin Ross
> Priority: Minor
> Fix For: proton-c-0.18.0
>
>
> Same output as described in https://issues.apache.org/jira/browse/QPID-7860
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
