ASF GitHub Bot commented on DISPATCH-803:

Github user ted-ross commented on a diff in the pull request:

    --- Diff: src/router_core/connections.c ---
    @@ -1300,9 +1310,15 @@ static void 
qdr_link_inbound_first_attach_CT(qdr_core_t *core, qdr_action_t *act
                     // This link has a target address
    -                bool           link_route;
    -                qdr_address_t *addr = qdr_lookup_terminus_address_CT(core, 
dir, conn, target, true, true, &link_route);
    -                if (!addr) {
    +                bool  link_route;
    +                bool  forbidden;
    +                qdr_address_t *addr = qdr_lookup_terminus_address_CT(core, 
dir, conn, target, true, true, &link_route, &forbidden);
    +                if (forbidden) {
    +                    qdr_link_outbound_detach_CT(core, link, 0, 
    --- End diff --
    Does this do the right thing protocol-wise?  Does the router send an attach 
with NULL terminus followed by a detach?

> refuse attach to undefined addresses
> ------------------------------------
>                 Key: DISPATCH-803
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-803
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>            Reporter: Gordon Sim
>            Assignee: Ganesh Murthy
>             Fix For: 1.0.0
> At present, if you attach to an address in the router whose semantics have 
> not been specifically defined, you get balanced message routing semantics.
> It would be useful to be able to configure the router such that it would 
> refuse links whose source/target was not explicitly defined. E.g. by being 
> able to configure the default semantics to be of type 'invalid' (or anything 
> similar). (Being able to explicitly blacklist certain addresses might also be 
> nice, but is a more exotic use case I think).
> Messages sent through an anonymous link to these 'invalid' addresses would be 
> rejected.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to