-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61596/#review182725
-----------------------------------------------------------



This looks fine.

Can you just confirm that adding this extra field to the frame is still amqp 
1.0 protocol compliant (I dont have time to check that today).

- Andrew Stitcher


On Aug. 11, 2017, 5:24 p.m., Gordon Sim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61596/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2017, 5:24 p.m.)
> 
> 
> Review request for qpid and Andrew Stitcher.
> 
> 
> Bugs: PROTON-1535
>     https://issues.apache.org/jira/browse/PROTON-1535
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> allow hostname to be set for sasl-init
> 
> 
> Diffs
> -----
> 
>   proton-c/include/proton/sasl-plugin.h cbc6684 
>   proton-c/src/sasl/sasl-internal.h fc141b4 
>   proton-c/src/sasl/sasl.c a39e602 
> 
> 
> Diff: https://reviews.apache.org/r/61596/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>

Reply via email to