[ 
https://issues.apache.org/jira/browse/PROTON-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Itamar Landsman updated PROTON-1558:
------------------------------------
    Description: 
When installing python-qpid-proton from pip there is no ssl support.
Trying to build the package (pip download, untar and setup.py build) I get a 
warning about OpenSSL not installed:

{quote}» python setup.py build
running build
running build_ext
running configure
Warning: command not found: pkg-config
Building the bundled proton-c sources into the extension
Warning: command not found: pkg-config
Warning: OpenSSL not installed - disabling SSL support!
creating build
.
.
.
{quote}

And indeed SSL is not available for the resulting built package.

A hack fix is to go into setup.py and edit the section where the presence of 
OpenSSL is verified:
{quote}\# Check whether openssl is installed by poking
        \# pkg-config for a minimum version 0. If it's installed, it should
        \# return True and we'll use it. Otherwise, we'll use the stub.
        if misc.pkg_config_version_installed('openssl', atleast='0'):
            libraries += ['ssl', 'crypto']
            sources.append(os.path.join(proton_src, 'ssl', 'openssl.c'))
        else:
            sources.append(os.path.join(proton_src, 'ssl', 'ssl_stub.c'))
            log.warn("OpenSSL not installed - disabling SSL support!"){quote}

Change to:
{quote}\# Check whether openssl is installed by poking
        \# pkg-config for a minimum version 0. If it's installed, it should
        \# return True and we'll use it. Otherwise, we'll use the stub.
        if True:
            libraries += ['ssl', 'crypto']
            sources.append(os.path.join(proton_src, 'ssl', 'openssl.c'))
        else:
            sources.append(os.path.join(proton_src, 'ssl', 'ssl_stub.c'))
            log.warn("OpenSSL not installed - disabling SSL support!"){quote}

Now, package is indeed built with SSL support.

The library discovery mechanism needs to be fixed, I expect.

  was:
When installing python-qpid-proton from pip there is no ssl support.
Trying to build the package (pip download, untar and setup.py build) I get a 
warning about OpenSSL not installed:

{quote}» python setup.py build
running build
running build_ext
running configure
Warning: command not found: pkg-config
Building the bundled proton-c sources into the extension
Warning: command not found: pkg-config
Warning: OpenSSL not installed - disabling SSL support!
creating build
.
.
.
{quote}

And indeed SSL is not available for the resulting built package.

A hack fix is to go into setup.py and edit the section where the presence of 
OpenSSL is verified:
{quote}# Check whether openssl is installed by poking
        # pkg-config for a minimum version 0. If it's installed, it should
        # return True and we'll use it. Otherwise, we'll use the stub.
        if misc.pkg_config_version_installed('openssl', atleast='0'):
            libraries += ['ssl', 'crypto']
            sources.append(os.path.join(proton_src, 'ssl', 'openssl.c'))
        else:
            sources.append(os.path.join(proton_src, 'ssl', 'ssl_stub.c'))
            log.warn("OpenSSL not installed - disabling SSL support!"){quote}

Change to:
{quote}# Check whether openssl is installed by poking
        # pkg-config for a minimum version 0. If it's installed, it should
        # return True and we'll use it. Otherwise, we'll use the stub.
        if True:
            libraries += ['ssl', 'crypto']
            sources.append(os.path.join(proton_src, 'ssl', 'openssl.c'))
        else:
            sources.append(os.path.join(proton_src, 'ssl', 'ssl_stub.c'))
            log.warn("OpenSSL not installed - disabling SSL support!"){quote}

Now, package is indeed built with SSL support.

The library discovery mechanism needs to be fixed, I expect.


> pypi setup.py fails to find openssl un ubuntu
> ---------------------------------------------
>
>                 Key: PROTON-1558
>                 URL: https://issues.apache.org/jira/browse/PROTON-1558
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: python-binding
>    Affects Versions: 0.17.0
>         Environment: Ubuntu 16.04
>            Reporter: Itamar Landsman
>
> When installing python-qpid-proton from pip there is no ssl support.
> Trying to build the package (pip download, untar and setup.py build) I get a 
> warning about OpenSSL not installed:
> {quote}» python setup.py build
> running build
> running build_ext
> running configure
> Warning: command not found: pkg-config
> Building the bundled proton-c sources into the extension
> Warning: command not found: pkg-config
> Warning: OpenSSL not installed - disabling SSL support!
> creating build
> .
> .
> .
> {quote}
> And indeed SSL is not available for the resulting built package.
> A hack fix is to go into setup.py and edit the section where the presence of 
> OpenSSL is verified:
> {quote}\# Check whether openssl is installed by poking
>         \# pkg-config for a minimum version 0. If it's installed, it should
>         \# return True and we'll use it. Otherwise, we'll use the stub.
>         if misc.pkg_config_version_installed('openssl', atleast='0'):
>             libraries += ['ssl', 'crypto']
>             sources.append(os.path.join(proton_src, 'ssl', 'openssl.c'))
>         else:
>             sources.append(os.path.join(proton_src, 'ssl', 'ssl_stub.c'))
>             log.warn("OpenSSL not installed - disabling SSL support!"){quote}
> Change to:
> {quote}\# Check whether openssl is installed by poking
>         \# pkg-config for a minimum version 0. If it's installed, it should
>         \# return True and we'll use it. Otherwise, we'll use the stub.
>         if True:
>             libraries += ['ssl', 'crypto']
>             sources.append(os.path.join(proton_src, 'ssl', 'openssl.c'))
>         else:
>             sources.append(os.path.join(proton_src, 'ssl', 'ssl_stub.c'))
>             log.warn("OpenSSL not installed - disabling SSL support!"){quote}
> Now, package is indeed built with SSL support.
> The library discovery mechanism needs to be fixed, I expect.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to