[ 
https://issues.apache.org/jira/browse/DISPATCH-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172080#comment-16172080
 ] 

ASF GitHub Bot commented on DISPATCH-824:
-----------------------------------------

Github user ganeshmurthy closed the pull request at:

    https://github.com/apache/qpid-dispatch/pull/198


> Remove deprecated entities and attributes from the router schema.
> -----------------------------------------------------------------
>
>                 Key: DISPATCH-824
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-824
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Container
>    Affects Versions: 0.8.0
>            Reporter: Ganesh Murthy
>            Assignee: Ganesh Murthy
>            Priority: Blocker
>             Fix For: 1.0.0
>
>
> As Dispatch is coming up on a major 1.0 release, the following deprecated 
> entities/attributes must be removed from the schema
> routerId, mobileAddrMaxAge attributes from the router entity
> {noformat}
>                 "routerId": {
>                     "description":"(DEPRECATED) Router's unique identity. 
> This attribute has been deprecated. Use id instead",
>                     "type": "string",
>                     "required": false,
>                     "deprecated": true,
>                     "create": true
>                 },
>                 "mobileAddrMaxAge": {
>                     "type": "integer",
>                     "default": 60,
>                     "deprecated": true,
>                     "description": "(DEPRECATED) This value is no longer used 
> in the router.",
>                     "create": true
>                 },
> {noformat}
> addr, allowUnsecured, allowNoSasl, requirePeerAuth  attributes in listener 
> entity
> {noformat}
>                 "addr": {
>                     "description":"(DEPRECATED)IP address: ipv4 or ipv6 
> literal or a host name. This attribute has been deprecated. Use host instead",
>                     "deprecated": true,
>                     "type": "string",
>                     "default": "",
>                     "create": true
>                 },
>                 "allowNoSasl": {
>                     "type": "boolean",
>                     "create": true,
>                     "deprecated": true,
>                     "description": "(DEPRECATED) This attribute is now 
> controlled by the authenticatePeer attribute."
>                 },
>                 "requirePeerAuth": {
>                     "type": "boolean",
>                     "create": true,
>                     "deprecated": true,
>                     "description": "(DEPRECATED) This attribute is now 
> controlled by the authenticatePeer attribute."
>                 },
>                 "allowUnsecured": {
>                     "type": "boolean",
>                     "create": true,
>                     "deprecated": true,
>                     "description": "(DEPRECATED) This attribute is now 
> controlled by the requireEncryption attribute."
>                 },
> {noformat}
> addr  attribute in connector entity
> {noformat}
>                 "addr": {
>                     "description":"(DEPRECATED)IP address: ipv4 or ipv6 
> literal or a host name. This attribute has been deprecated. Use host instead",
>                     "deprecated": true,
>                     "type": "string",
>                     "default": "127.0.0.1",
>                     "create": true
>                 },
> {noformat}
> Remove the container entity
> {noformat}
>         "container": {
>             "description":"(DEPRECATED)Attributes related to the AMQP 
> container. This entity has been deprecated. Use the router entity instead.",
>             "extends": "configurationEntity",
>             "deprecated": true,
>             "singleton": true,
>             "attributes": {
>                 "containerName": {
>                     "type": "string",
>                     "description": "The  name of the AMQP container.  If not 
> specified, the container name will be set to a value of the container's 
> choosing.  The automatically assigned container name is not guaranteed to be 
> persistent across restarts of the container.",
>                     "create": true
>                 },
>                 "workerThreads": {
>                     "type": "integer",
>                     "default": 4,
>                     "description": "The number of threads that will be 
> created to process message traffic and other application work (timers, 
> non-amqp file descriptors, etc.) .",
>                     "create": true
>                 },
>                 "debugDump": {
>                     "type": "path",
>                     "description": "A file to dump debugging information that 
> can't be logged normally.",
>                     "create": true
>                 },
>                 "saslConfigPath": {
>                     "type": "path",
>                     "description": "Absolute path to the SASL configuration 
> file.",
>                     "required": false,
>                     "create": true
>                 },
>                 "saslConfigName": {
>                     "type": "string",
>                     "description": "Name of the SASL configuration.  This 
> string + '.conf' is the name of the configuration file.",
>                     "required": false,
>                     "create": true
>                 }
>             }
>         },
> {noformat}
> Remove waypoint, linkRoutePattern, fixedAddress entities.
> {noformat}
>         "waypoint": {
>             "description":"(DEPRECATED) A remote node that messages for an 
> address pass through. This entity has been deprecated. Use autoLink instead",
>             "deprecated": true,
>             "extends": "configurationEntity",
>             "operations": ["CREATE", "DELETE"],
>             "attributes": {
>                 "address": {
>                     "description":"The AMQP address of the waypoint.",
>                     "type": "string",
>                     "required": true,
>                     "create": true
>                 },
>                 "connector": {
>                     "description":"The name of the on-demand connector used 
> to reach the waypoint's container.",
>                     "type": "string",
>                     "required": true,
>                     "create": true
>                 },
>                 "inPhase": {
>                     "description":"The phase of the address as it is routed 
> _to_ the waypoint.",
>                     "type": "integer",
>                     "default": -1,
>                     "create": true
>                 },
>                 "outPhase": {
>                     "description":"The phase of the address as it is routed 
> _from_ the waypoint.",
>                     "type": "integer",
>                     "default": -1,
>                     "create": true
>                 }
>             }
>         },
>         "fixedAddress": {
>             "description":"(DEPRECATED) Establishes treatment for addresses 
> starting with a prefix. This entity has been deprecated. Use address instead",
>             "extends": "configurationEntity",
>             "deprecated": true,
>             "operations": ["CREATE"],
>             "attributes": {
>                 "prefix": {
>                     "type": "string",
>                     "required": true,
>                     "description": "The address prefix (always starting with 
> '/').",
>                     "create": true
>                 },
>                 "phase": {
>                     "type": "integer",
>                     "description": "The phase of a multi-hop address passing 
> through one or more waypoints.",
>                     "create": true
>                 },
>                 "fanout": {
>                     "type": [
>                         "multiple",
>                         "single"
>                     ],
>                     "default": "multiple",
>                     "description": "One of 'multiple' or 'single'.  Multiple 
> fanout is a non-competing pattern.  If there are multiple consumers using the 
> same address, each consumer will receive its own copy of every message sent 
> to the address.  Single fanout is a competing pattern where each message is 
> sent to only one consumer.",
>                     "create": true
>                 },
>                 "bias": {
>                     "type": [
>                         "closest",
>                         "spread"
>                     ],
>                     "default": "closest",
>                     "description": "Only if fanout is single.  One of 
> 'closest' or 'spread'.  Closest bias means that messages to an address will 
> always be delivered to the closest (lowest cost) subscribed consumer. Spread 
> bias will distribute the messages across subscribers in an approximately even 
> manner.",
>                     "create": true
>                 }
>             }
>         },
>         "linkRoutePattern": {
>             "description":"(DEPRECATED) An address pattern to match against 
> link sources and targets to cause the router to link-route the attach across 
> the network to a remote node. This entity has been deprecated. Use linkRoute 
> instead",
>             "deprecated": true,
>             "extends": "configurationEntity",
>             "operations": ["CREATE"],
>             "attributes": {
>                 "prefix": {
>                     "description":"An address prefix to match against target 
> and source addresses.  This pattern must be of the form 
> '<text>.<text1>.<textN>' or '<text>' or '<text>.' and matches any address 
> that contains that prefix.  For example, if the prefix is set to org.apache 
> (or org.apache.), any address that has the prefix 'org.apache'  (like 
> org.apache.dev) will match. Note that a prefix must not start with a (.), can 
> end in a (.) and can contain zero or more dots (.).  Any characters between 
> the dots are simply treated as part of the address",
>                     "type": "string",
>                     "required": true,
>                     "create": true
>                 },
>                 "dir": {
>                     "description":"Link direction for match: 'in' matches 
> only links inbound to the client; 'out' matches only links outbound from the 
> client; 'both' matches any link.",
>                     "type": ["in", "out", "both"],
>                     "required": false,
>                     "default": "both",
>                     "create": true
>                 },
>                 "connector": {
>                     "description":"The name of the on-demand connector used 
> to reach the target node's container.  If this value is not provided, it 
> means that the target container is expected to be connected to a different 
> router in the network.  This prevents links to a link-routable address from 
> being misinterpreted as message-routing links when there is no route to a 
> valid destination available.",
>                     "type": "string",
>                     "required": false,
>                     "default": "",
>                     "create": true
>                 }
>             }
>         },
> {noformat}
> Remove on-demand role from listener and container.
> {noformat}
>                 "role": {
>                     "type": [
>                         "normal",
>                         "inter-router",
>                         "route-container",
>                         "on-demand"
>                     ],
>                     "default": "normal",
>                     "description": "The role of an established connection. In 
> the normal role, the connection is assumed to be used for AMQP clients that 
> are doing normal message delivery over the connection.  In the inter-router 
> role, the connection is assumed to be to another router in the network.  
> Inter-router discovery and routing protocols can only be used over 
> inter-router connections. route-container role can be used for 
> router-container connections, for example, a router-broker connection.",
>                     "create": true
>                 },
> {noformat}
> Remove all deprecated references from source code and also modify/fix unit 
> tests that reference these deprecated attributes/entities



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to