[
https://issues.apache.org/jira/browse/PROTON-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193414#comment-16193414
]
ASF GitHub Bot commented on PROTON-1606:
----------------------------------------
GitHub user timtay-microsoft opened a pull request:
https://github.com/apache/qpid-proton-j/pull/11
PROTON-1606: Added ability to make SASL communication optional
Previously, the IOhandler created to be the global handler automatically
created the SASL layer whether a user of the library wanted it or not. This
commit exposes an option when creating the reactor to disable creating the SASL
layer at all.
https://issues.apache.org/jira/browse/PROTON-1606
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/timtay-microsoft/qpid-proton-j
clientSaslOptionality
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton-j/pull/11.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11
----
commit 965bc73893f887a15b1558891039d0a5cb7556eb
Author: timtay-microsoft <[email protected]>
Date: 2017-10-05T18:40:28Z
PROTON-1606: Added ability to make SASL communication optional for CLIENT
role
Previously, the IOhandler created to be the global handler automatically
created the SASL layer whether a user of the library wanted it or not. This
commit exposes an option when creating the reactor to disable creating the SASL
layer at all.
https://issues.apache.org/jira/browse/PROTON-1606
----
> (Proton-J) Using Sasl needs to be optional for Client Role
> ----------------------------------------------------------
>
> Key: PROTON-1606
> URL: https://issues.apache.org/jira/browse/PROTON-1606
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-j
> Affects Versions: proton-j-0.22.0
> Environment: N/A
> Reporter: Tim Taylor
> Original Estimate: 8h
> Remaining Estimate: 8h
>
> In order for my application to use Proton-j for amqps messaging, the Sasl
> layer cannot be created by the global handler (IOHandler) at
> CONNECTION_LOCAL_OPEN time. The code below breaks our ability to use proton-j
> for amqps messaging as a CLIENT against our service.
> ...
> sasl = transport.sasl();
> sasl.client();
> sasl.setMechanisms("ANONYMOUS");
> ...
> I need these three lines of code to be optional in the global handler, or for
> a new API that allows a transport implementation to undo creating the Sasl
> layer.
> Something like:
> ....
> Transport transport = event.getConnection().getTransport();
> transport.disableSasl();
> ....
> The service I am hitting against is not using Proton-j as the SERVER role.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
