Github user chrisrichardson77 commented on a diff in the pull request:
https://github.com/apache/qpid-cpp/pull/10#discussion_r143973175
--- Diff: src/qpid/broker/SelectorToken.h ---
@@ -69,7 +69,8 @@ struct Token {
std::string val;
std::string::const_iterator tokenStart;
- Token()
+ Token() :
+ type()
--- End diff --
The base type of an enum is a primitive integral type so it is correct to
initialise it here. However "type()" will assign zero to the variable
irrespective of whether that is a valid enum element - perhaps better to
explicitly assign an enum element eg: type(T_EOS) (if that was the intention)
or type(T_NULL).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
