[
https://issues.apache.org/jira/browse/QPID-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16203790#comment-16203790
]
Alex Rudyy commented on QPID-7913:
----------------------------------
I think that aggregation of warnings for unknown message instances per queue
could be a bad idea.
With current implementation, the warning is issued per message instance before
message instance is deleted. Thus, in situation when Broker runs out of
memory, all the warnings will be logged. If we change the recoverers to issue
warning per queue for unknown message instances and OOM error is thrown in the
middle of recovery, the information about deleted message instances might not
be logged to the end users. I attached a patch which allow aggregation of the
information about the deleted message instances per queue and logging warnings
per each queue but I am not sure that we should commit the patch.
> [Java Broker] Improve message recovery logging
> ----------------------------------------------
>
> Key: QPID-7913
> URL: https://issues.apache.org/jira/browse/QPID-7913
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: qpid-java-6.0, qpid-java-6.1, qpid-java-broker-7.0.0
> Reporter: Alex Rudyy
> Priority: Minor
> Fix For: qpid-java-broker-7.0.0
>
> Attachments:
> 0001-QPID-7913-Java-Broker-Log-a-single-warning-per-queue.patch
>
>
> Qpid broker message store recoverer generates a warning for every discarded
> message as below
> {noformat}
> WARN [VirtualHostNode-default-Config]
> (o.a.q.s.v.SynchronousMessageStoreRecoverer) - Message id 11800003 in log
> references queue with id de12d20b-bf6c-4d7b-a216-f613ee0635ae which is not in
> the configuration, entry will be discarded
> {noformat}
> Potentially, the logging can be improved to generate a single log entry per
> queue rather that per each message, where a number of discarded messages and
> their ids can be reported.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
