[ https://issues.apache.org/jira/browse/PROTON-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204859#comment-16204859 ]
Justin Ross commented on PROTON-1619: ------------------------------------- Removing the connection driver log functions breaks libqpid-proton-core ABI versus 0.17.0. I think we should reinstate and deprecate them. {noformat} [jross@localhost qpid-proton-ssorj (ssorj-versions)]$ abigail /usr/lib64/libqpid-proton-core.so /tmp/tmp.nzVXqRTato/lib64/libqpid-proton-core.so abigail: Calling 'nm --dynamic --demangle --defined-only /usr/lib64/libqpid-proton-core.so' abigail: Calling 'nm --dynamic --demangle --defined-only /tmp/tmp.nzVXqRTato/lib64/libqpid-proton-core.so' 37 symbols added 2 symbols removed Added: pn_collector_drain Added: pn_connection_driver_release_connection Added: pn_delivery_abort [...] Added: pnx_sasl_set_local_hostname Added: pnx_sasl_set_selected_mechanism Added: pnx_sasl_succeed_authentication Removed: pn_connection_driver_log Removed: pn_connection_driver_vlogf {noformat} > C and C++ API clean up > ---------------------- > > Key: PROTON-1619 > URL: https://issues.apache.org/jira/browse/PROTON-1619 > Project: Qpid Proton > Issue Type: Task > Components: cpp-binding, proton-c > Reporter: Justin Ross > Assignee: Alan Conway > Fix For: proton-c-0.18.0 > > > From our review. > Use pni_ prefix > - pn_log_enabled > - pn_logf_impl > - pn_vlogf_impl > Remove or don't export > - pn_message_get_extra > - pn_message_with_extra > - pn_connection_driver_logf > - pni_parse_url -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org