[
https://issues.apache.org/jira/browse/QPID-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212334#comment-16212334
]
Keith Wall commented on QPID-7832:
----------------------------------
Hi Rob, Sorry I overlooked the arrival of your comments. Yes, point taken,
with hindsight that would have been a better way to proceed. That said, much
of the size of the patch actually came from fixing of (existing and new for v7)
QBB direct leaks (some new with v7, some existing with lots associated with the
handling of buffers after error conditions) rather than the change directly.
This contributed lots of try-with-resources noise. It would have been
preferable if this was separated from the initial refactor.
> Refactor store/protocol API using Collection<QpidByteBuffers>
> -------------------------------------------------------------
>
> Key: QPID-7832
> URL: https://issues.apache.org/jira/browse/QPID-7832
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Priority: Minor
> Fix For: qpid-java-broker-7.0.0
>
> Attachments:
> 0001-QPID-7832-Java-Broker-Refactor-store-protocol-API-us.patch
>
>
> Store/protocol APIs have gradually been evolving to accept/return message
> content/message metadata in terms of an ordered list of QBBs. This has lead
> to use of helper methods such as those in QBBUtils which read from a list of
> buffers rather than a single one.
> This would be better refactored. QpidByteBuffer should be an interface.
> This would allow a concrete implementation CompositeQpidByteBuffer which is
> backed by a list produced by the store or network IO.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
