[
https://issues.apache.org/jira/browse/PROTON-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240382#comment-16240382
]
ASF GitHub Bot commented on PROTON-1342:
----------------------------------------
Github user astitcher commented on the issue:
https://github.com/apache/qpid-proton/pull/128
I like this latest version, but 2 remaining things:
* Please, please rebase and squash this to be a single commit - this chain
of development makes no sense as part of the project history.
* A niggle really - you didn't follow the existing formatting of the yaml
file. Specifically you indent follow on lists, this just pushes everything
further right and makes it harder to read long lines. The existing style is
like this:
```yaml
before_install:
- eval ...
- if ...
- if ...
```
> CI on OS X
> ----------
>
> Key: PROTON-1342
> URL: https://issues.apache.org/jira/browse/PROTON-1342
> Project: Qpid Proton
> Issue Type: Task
> Components: proton-c
> Reporter: Justin Ross
> Labels: osx, testing
> Fix For: proton-c-future
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
