[ 
https://issues.apache.org/jira/browse/QPID-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245400#comment-16245400
 ] 

ASF subversion and git services commented on QPID-7899:
-------------------------------------------------------

Commit 8443f85a5b5540276af271048f48cb5d98038517 in qpid-jms-amqp-0-x's branch 
refs/heads/master from [~lorenz.quack]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms-amqp-0-x.git;h=8443f85 ]

QPID-7897, QPID-7899: [Java Client, AMQP 0-x] Add missing copyright header to 
test file


> [Java 0-8...0-9-1 Client] Message#setJMSCorrelationIDAsBytes() erroneously 
> converts the bytes to string
> -------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-7899
>                 URL: https://issues.apache.org/jira/browse/QPID-7899
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>            Reporter: Lorenz Quack
>             Fix For: qpid-java-client-0-x-6.3.0
>
>
> The client converts the {{byte[]}} passed in to 
> {{javax.jms.Message#setJMSCorrelationIDAsBytes}} to a String via {{new 
> String(bytes);}}.
> If the bytes are not the encoding of a String in the current default encoding 
> (in which case why would you use this method in the first place), this is 
> wrong.
> In the JMS API implementation of  
> {{setJMSCorrelationIDAsBytes()/getJMSCorrelationIDAsBytes()}} is optional and 
> it explicitly allows the provider to throw 
> {{java.lang.UnsupportedOperationException}}.
> We should either pack the raw bytes into the {{AMQShortString}} or throw 
> {{UnsupportedOperationException}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to