Github user gemmellr commented on the issue:
https://github.com/apache/qpid-proton-j/pull/12
Hi Franz
Thanks for the PR. I have some feedback for changes that would be good
and/or necessary.
The JMH dependencies are not ALv2 compatible and so I think we should make
it an optional module, which doesn't deploy anything. I think it will often be
true people wont want to run those tests regularly enough to warrant including
them with every build, so I think it also makes sense to make it optional for
that reason anyway. Making it so unfortunately adds some issues around
versioning during the release, as we will still want the module versions to get
updated, so we need to adjust the process slightly to handle that. I'd also
suggest that we move them under the tests directory.
I've had a stab at making the build/release work with this all in mind,
going with tests/performance-jmh as the new directory. I've pasted a patch at
https://paste.apache.org/lgCc with some of the changes. The changes for the
root pom.xml are the diff from master, instead of those here rather than on
top, while the tests/performance-jmh/pom.xml is the full new file I ended up
with rather than a diff from here. With the updated poms, the module can be
enabled as part of the overall build by adding -Pperformance-jmh, or it can
just be built serparately using its own pom directly. Theres some trickery in
there to ensure the release is performed in a way that updates the versions, or
else fails.
The LICENSE file being added here can be removed, its covered by the one in
the root dir already.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
