> On Dec. 20, 2017, 2:46 p.m., Ganesh Murthy wrote: > > src/remote_sasl.c > > Lines 73 (patched) > > <https://reviews.apache.org/r/64645/diff/1/?file=1918362#file1918362line73> > > > > Should these data structure names be preceeded by a qd_ ? > > > > Like so, permissions_t would be qd_permissions_t
These structs are not visible outside remote_sasl.c. For permissions_t I could certainly prefix that if desired. For buffer_t (which is what permissions_t contains) I can't prefix that or it would clash with an existing definition. Personally I quite like the pn_ and qd_ being kept for more visible types. However I'm certainly happy to comply with any defined convention. )Though as above, for buffer_t, if prefixing is required I'll need to think up a new name!). - Gordon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64645/#review194246 ----------------------------------------------------------- On Dec. 20, 2017, 5:40 p.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64645/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2017, 5:40 p.m.) > > > Review request for qpid, Chug Rolke, Ganesh Murthy, and Ted Ross. > > > Bugs: DISPATCH-901 > https://issues.apache.org/jira/browse/DISPATCH-901 > > > Repository: qpid-dispatch > > > Description > ------- > > If the client specifies its desire for the ADDRESS-AUTHZ capacbility, the > authorization service, if it supports this, will return a set of permissions > in the properties of the open frame. The properties will have an > address-authz key, whose value is a map of address (or wildcard pattern) to > an array of permissions. The only permissions recognised at present by this > patch are 'send' and 'recv'. > > > Diffs > ----- > > src/policy.c 22cc79f > src/remote_sasl.c e3c969b > tests/CMakeLists.txt 0c6454c > tests/authservice.py PRE-CREATION > tests/system_tests_authz_service_plugin.py PRE-CREATION > > > Diff: https://reviews.apache.org/r/64645/diff/4/ > > > Testing > ------- > > Added new systems tests using proton python based dummy auth service. > > > Thanks, > > Gordon Sim > >
