Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/226#discussion_r158315973
--- Diff: tests/system_tests_one_router.py ---
@@ -1552,6 +1552,14 @@ def check_if_done(self):
self.conn.close()
elif self.n_sent == self.n_released:
self.error = None
+
+ if not self.error:
--- End diff --
This 'if' is unnecessary. Also, this test doesn't send pre-settled
deliveries. Why does it expect a count of dropped pre-settleds?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
