Github user astitcher commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/135#discussion_r160062571
  
    --- Diff: .travis.yml ---
    @@ -23,29 +23,37 @@ compiler:
     - gcc
     - clang
     
    +env:
    +- PIP='pip'
    +
     matrix:
       include:
       - os: linux
         env:
         - QPID_PROTON_CMAKE_ARGS='-DCMAKE_BUILD_TYPE=Coverage'
    +    - PIP='pip'
    --- End diff --
    
    I think we may be talking about the opposite case:
    - I'm suggesting that this line which part of a specific matrix build is 
not necessary because there is a line in the non matrix case.
    - I think you are saying that not having the non matrix line doesn't work. 
I agree with this.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to