[
https://issues.apache.org/jira/browse/PROTON-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320749#comment-16320749
]
ASF subversion and git services commented on PROTON-1739:
---------------------------------------------------------
Commit 6fa847b1ef9de9d0accffeecdd1e5525167235d6 in qpid-proton-j's branch
refs/heads/master from [~gemmellr]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton-j.git;h=6fa847b ]
PROTON-1739: remove default for session capacity and avoid confusing window
interaction when setting frame size
> remove confusing default for session capacity and allow disabling it
> --------------------------------------------------------------------
>
> Key: PROTON-1739
> URL: https://issues.apache.org/jira/browse/PROTON-1739
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-j
> Affects Versions: proton-j-0.24.0
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: proton-j-0.25.0
>
>
> The session has a default 'incoming capacity' of 1MB, which actually has no
> effect by default and leads to unexpected behaviour while changing other
> configuration. It should be removed.
> The value is used when the engine decides what incoming session window to set
> on Flow frames, but only if a specific frame size is configured for the
> transport, which it isn't by default. If a specific frame size is set, then
> any session capacity really needs to be set based on it in order to be
> appropriate, the default being fixed as it is leads to unexpectedly low
> window sizes in many cases which will impact performance in unexpected ways.
> Its confusing that setting frame size results in completely different
> behaviour than before for another thing (window size) which perhaps hasn't
> been configured at all, and the existing behaviour is also such that you cant
> turn it off.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
