Github user ssorj commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/244#discussion_r163344546
  
    --- Diff: python/qpid_dispatch/management/qdrouter.json ---
    @@ -1126,6 +1126,106 @@
                 }
             },
     
    +        "router.config.exchange": {
    +            "description":"[EXPERIMENTAL] Defines a topic exchange.",
    +            "extends": "configurationEntity",
    +            "operations": ["CREATE", "DELETE"],
    +            "attributes": {
    +                "address": {
    --- End diff --
    
    I think address on router.node should change to "addr".  It's the only 
outlier.  The rest of the config is using "addr" consistently.
    
    Side note: "address" for one address and "addr" for multiple addresses is 
an automatic user gotcha.  There is zero help for the user in those names.
    
    And data point: The doc for "addr" on autoLink says it is just one address.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to