Github user kgiusti commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/249#discussion_r164544618
--- Diff: console/CMakeLists.txt ---
@@ -25,33 +25,46 @@ set(CONSOLE_BASE_SOURCE_DIR
"${CMAKE_SOURCE_DIR}/console/stand-alone/")
option(CONSOLE_INSTALL "Install stand-alone console" ON)
if(CONSOLE_INSTALL)
- # Static console files
- install(
- DIRECTORY ${CONSOLE_BASE_SOURCE_DIR}
+ # Static console files
+ install(
+ DIRECTORY ${CONSOLE_BASE_SOURCE_DIR}
DESTINATION ${CONSOLE_STAND_ALONE_INSTALL_DIR}
)
+ # run npm install for console if npm is installed
+ find_program(PROG_NPM npm)
+ if (PROG_NPM STREQUAL "PROG_NPM-NOTFOUND")
+ message(WARNING "Program npm not found. You must manually install
console dependencies.")
--- End diff --
Hey - turns out the WARNING keyword is not supported with the minimum Cmake
version we require.
But I think this is the Right Way to do it, and since Proton's minimum
Cmake is set to 2.8.12 we should update our cmake_minimum_version to the same.
Can you update this patch and change the cmake_minimum_version in the
topmost CMakeLists.txt fileto 2.8.12?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
