[
https://issues.apache.org/jira/browse/DISPATCH-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343909#comment-16343909
]
ASF GitHub Bot commented on DISPATCH-921:
-----------------------------------------
Github user kgiusti commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/249#discussion_r164544618
--- Diff: console/CMakeLists.txt ---
@@ -25,33 +25,46 @@ set(CONSOLE_BASE_SOURCE_DIR
"${CMAKE_SOURCE_DIR}/console/stand-alone/")
option(CONSOLE_INSTALL "Install stand-alone console" ON)
if(CONSOLE_INSTALL)
- # Static console files
- install(
- DIRECTORY ${CONSOLE_BASE_SOURCE_DIR}
+ # Static console files
+ install(
+ DIRECTORY ${CONSOLE_BASE_SOURCE_DIR}
DESTINATION ${CONSOLE_STAND_ALONE_INSTALL_DIR}
)
+ # run npm install for console if npm is installed
+ find_program(PROG_NPM npm)
+ if (PROG_NPM STREQUAL "PROG_NPM-NOTFOUND")
+ message(WARNING "Program npm not found. You must manually install
console dependencies.")
--- End diff --
Hey - turns out the WARNING keyword is not supported with the minimum Cmake
version we require.
But I think this is the Right Way to do it, and since Proton's minimum
Cmake is set to 2.8.12 we should update our cmake_minimum_version to the same.
Can you update this patch and change the cmake_minimum_version in the
topmost CMakeLists.txt fileto 2.8.12?
> Install console dependencies with npm during make install
> ---------------------------------------------------------
>
> Key: DISPATCH-921
> URL: https://issues.apache.org/jira/browse/DISPATCH-921
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Console
> Affects Versions: 1.0.0
> Reporter: Ernest Allen
> Assignee: Ernest Allen
> Priority: Major
>
> During a make install, the stand-alone console's dependencies should be
> installed using the command 'npm install' executed from the console's install
> directory.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
